Ensure pietestgui is installed - #7
Merged
michaelhatPIengineering merged 4 commits intoApr 9, 2021
Merged
Conversation
Signed-off-by: Christoph Willing <chris.willing@linux.com>
Contributor
Author
|
The current 'configure/make/make install' omits installing pietestgui. This PR adds pietestgui to the installation list. |
Open
Contributor
|
I would be happy to merge this but there are conflicts. <<<<<<< gui-executable INSTALL(TARGETS pietestgui
|
Contributor
Author
Contributor
|
ok thanks
Sorry I got it in the wrong order...
…________________________________
From: cwilling ***@***.***>
Sent: Friday, April 9, 2021 8:36 AM
To: piengineering/X-keys_Linux ***@***.***>
Cc: Michael Hetherington ***@***.***>; Comment ***@***.***>
Subject: Re: [piengineering/X-keys_Linux] Ensure pietestgui is installed (#7)
I'm not sure but it may be because #9<#9> was applied before #7<#7>. I'll reload what's in the repo right now and make a new PR. Leave this one as it is - I think I can make the changes in place. If not, I'll just submit a new PR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#7 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AS6L3QUN7DMSGG5GMIPLJUTTH3YGHANCNFSM42R3ABIA>.
|
Signed-off-by: Christoph Willing <chris.willing@linux.com>
Signed-off-by: Christoph Willing <chris.willing@linux.com>
Contributor
Author
|
Actually, it wasn't the ordering. It was because I made changes to the same file in different PRs, so my mistake. I've fixed it now so should be OK to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christoph Willing chris.willing@linux.com